Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen.cc ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 151
152 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 152 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
153 // Register state just before return from JS function (from codegen-ia32.cc). 153 // Register state just before return from JS function (from codegen-ia32.cc).
154 // ----------- S t a t e ------------- 154 // ----------- S t a t e -------------
155 // -- eax: return value 155 // -- eax: return value
156 // ----------------------------------- 156 // -----------------------------------
157 Generate_DebugBreakCallHelper(masm, eax.bit()); 157 Generate_DebugBreakCallHelper(masm, eax.bit());
158 } 158 }
159 159
160 160
161 void DebugCodegen::GenerateSlot(MacroAssembler* masm) { 161 void DebugCodegen::GenerateSlot(MacroAssembler* masm,
162 DebugCodegen::SlotLocation location,
163 int call_argc) {
162 // Generate enough nop's to make space for a call instruction. 164 // Generate enough nop's to make space for a call instruction.
163 Label check_codesize; 165 Label check_codesize;
164 __ bind(&check_codesize); 166 __ bind(&check_codesize);
167 RecordRelocInfo(masm, location, call_argc);
165 __ Nop(Assembler::kDebugBreakSlotLength); 168 __ Nop(Assembler::kDebugBreakSlotLength);
166 DCHECK_EQ(Assembler::kDebugBreakSlotLength, 169 DCHECK_EQ(Assembler::kDebugBreakSlotLength,
167 masm->SizeOfCodeGeneratedSince(&check_codesize)); 170 masm->SizeOfCodeGeneratedSince(&check_codesize));
168 } 171 }
169 172
170 173
171 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) { 174 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) {
172 Generate_DebugBreakCallHelper(masm, 0); 175 Generate_DebugBreakCallHelper(masm, 0);
173 } 176 }
174 177
(...skipping 29 matching lines...) Expand all
204 207
205 208
206 const bool LiveEdit::kFrameDropperSupported = true; 209 const bool LiveEdit::kFrameDropperSupported = true;
207 210
208 #undef __ 211 #undef __
209 212
210 } // namespace internal 213 } // namespace internal
211 } // namespace v8 214 } // namespace v8
212 215
213 #endif // V8_TARGET_ARCH_IA32 216 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen.cc ('k') | src/mips/debug-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698