Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/arm64/debug-arm64.cc

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/debug-arm.cc ('k') | src/debug.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 159
160 160
161 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 161 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
162 // In places other than IC call sites it is expected that r0 is TOS which 162 // In places other than IC call sites it is expected that r0 is TOS which
163 // is an object - this is not generally the case so this should be used with 163 // is an object - this is not generally the case so this should be used with
164 // care. 164 // care.
165 Generate_DebugBreakCallHelper(masm, x0.Bit()); 165 Generate_DebugBreakCallHelper(masm, x0.Bit());
166 } 166 }
167 167
168 168
169 void DebugCodegen::GenerateSlot(MacroAssembler* masm) { 169 void DebugCodegen::GenerateSlot(MacroAssembler* masm,
170 DebugCodegen::SlotLocation location,
171 int call_argc) {
170 // Generate enough nop's to make space for a call instruction. Avoid emitting 172 // Generate enough nop's to make space for a call instruction. Avoid emitting
171 // the constant pool in the debug break slot code. 173 // the constant pool in the debug break slot code.
172 InstructionAccurateScope scope(masm, Assembler::kDebugBreakSlotInstructions); 174 InstructionAccurateScope scope(masm, Assembler::kDebugBreakSlotInstructions);
173 175 RecordRelocInfo(masm, location, call_argc);
174 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) { 176 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) {
175 __ nop(Assembler::DEBUG_BREAK_NOP); 177 __ nop(Assembler::DEBUG_BREAK_NOP);
176 } 178 }
177 } 179 }
178 180
179 181
180 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) { 182 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) {
181 // In the places where a debug break slot is inserted no registers can contain 183 // In the places where a debug break slot is inserted no registers can contain
182 // object pointers. 184 // object pointers.
183 Generate_DebugBreakCallHelper(masm, 0); 185 Generate_DebugBreakCallHelper(masm, 0);
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 __ Br(scratch); 219 __ Br(scratch);
218 } 220 }
219 221
220 222
221 const bool LiveEdit::kFrameDropperSupported = true; 223 const bool LiveEdit::kFrameDropperSupported = true;
222 224
223 } // namespace internal 225 } // namespace internal
224 } // namespace v8 226 } // namespace v8
225 227
226 #endif // V8_TARGET_ARCH_ARM64 228 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/debug-arm.cc ('k') | src/debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698