Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: src/arm/debug-arm.cc

Issue 1229673005: Debugger: record reloc info for debug break slot immediate before the slot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/debug-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 115
116 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) { 116 void DebugCodegen::GenerateReturnDebugBreak(MacroAssembler* masm) {
117 // In places other than IC call sites it is expected that r0 is TOS which 117 // In places other than IC call sites it is expected that r0 is TOS which
118 // is an object - this is not generally the case so this should be used with 118 // is an object - this is not generally the case so this should be used with
119 // care. 119 // care.
120 Generate_DebugBreakCallHelper(masm, r0.bit()); 120 Generate_DebugBreakCallHelper(masm, r0.bit());
121 } 121 }
122 122
123 123
124 void DebugCodegen::GenerateSlot(MacroAssembler* masm) { 124 void DebugCodegen::GenerateSlot(MacroAssembler* masm,
125 DebugCodegen::SlotLocation location,
126 int call_argc) {
125 // Generate enough nop's to make space for a call instruction. Avoid emitting 127 // Generate enough nop's to make space for a call instruction. Avoid emitting
126 // the constant pool in the debug break slot code. 128 // the constant pool in the debug break slot code.
127 Assembler::BlockConstPoolScope block_const_pool(masm); 129 Assembler::BlockConstPoolScope block_const_pool(masm);
128 Label check_codesize; 130 Label check_codesize;
129 __ bind(&check_codesize); 131 __ bind(&check_codesize);
132 RecordRelocInfo(masm, location, call_argc);
130 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) { 133 for (int i = 0; i < Assembler::kDebugBreakSlotInstructions; i++) {
131 __ nop(MacroAssembler::DEBUG_BREAK_NOP); 134 __ nop(MacroAssembler::DEBUG_BREAK_NOP);
132 } 135 }
133 DCHECK_EQ(Assembler::kDebugBreakSlotInstructions, 136 DCHECK_EQ(Assembler::kDebugBreakSlotInstructions,
134 masm->InstructionsGeneratedSince(&check_codesize)); 137 masm->InstructionsGeneratedSince(&check_codesize));
135 } 138 }
136 139
137 140
138 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) { 141 void DebugCodegen::GenerateSlotDebugBreak(MacroAssembler* masm) {
139 // In the places where a debug break slot is inserted no registers can contain 142 // In the places where a debug break slot is inserted no registers can contain
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 182
180 183
181 const bool LiveEdit::kFrameDropperSupported = true; 184 const bool LiveEdit::kFrameDropperSupported = true;
182 185
183 #undef __ 186 #undef __
184 187
185 } // namespace internal 188 } // namespace internal
186 } // namespace v8 189 } // namespace v8
187 190
188 #endif // V8_TARGET_ARCH_ARM 191 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/debug-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698