src/x64/stub-cache-x64.cc - Issue 12296026: ES6 symbols: Implement Symbol intrinsic and basic functionality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 12296026: ES6 symbols: Implement Symbol intrinsic and basic functionality (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed more comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 23c444f467aa0c4123ea268eb8b7f8febacb54c5..4be5738756ea9a663c0bac5cc89ade52dbeae834 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -2262,6 +2262,12 @@ Handle<Code> CallStubCompiler::CompileCallConstant(Handle<Object> object,

}

break;

+ case SYMBOL_CHECK:

+ // Check that the object is a symbol.

+ __ CmpObjectType(rdx, SYMBOL_TYPE, rax);

+ __ j(not_equal, &miss);

+ break;

case NUMBER_CHECK:

if (function->IsBuiltin() || !function->shared()->is_classic_mode()) {

Label fast;

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/mjsunit/harmony/symbols.js » ('j') | no next file with comments »