Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 12296026: ES6 symbols: Implement Symbol intrinsic and basic functionality (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed more comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5454 matching lines...) Expand 10 before | Expand all | Expand 10 after
5465 __ j(equal, true_label); 5465 __ j(equal, true_label);
5466 __ CmpInstanceType(input, JS_FUNCTION_PROXY_TYPE); 5466 __ CmpInstanceType(input, JS_FUNCTION_PROXY_TYPE);
5467 final_branch_condition = equal; 5467 final_branch_condition = equal;
5468 5468
5469 } else if (type_name->Equals(heap()->object_string())) { 5469 } else if (type_name->Equals(heap()->object_string())) {
5470 __ JumpIfSmi(input, false_label); 5470 __ JumpIfSmi(input, false_label);
5471 if (!FLAG_harmony_typeof) { 5471 if (!FLAG_harmony_typeof) {
5472 __ CompareRoot(input, Heap::kNullValueRootIndex); 5472 __ CompareRoot(input, Heap::kNullValueRootIndex);
5473 __ j(equal, true_label); 5473 __ j(equal, true_label);
5474 } 5474 }
5475 __ CmpObjectType(input, FIRST_NONCALLABLE_SPEC_OBJECT_TYPE, input); 5475 if (FLAG_harmony_symbols) {
5476 __ CmpObjectType(input, SYMBOL_TYPE, input);
5477 __ j(equal, true_label);
5478 __ CmpInstanceType(input, FIRST_NONCALLABLE_SPEC_OBJECT_TYPE);
5479 } else {
5480 __ CmpObjectType(input, FIRST_NONCALLABLE_SPEC_OBJECT_TYPE, input);
5481 }
5476 __ j(below, false_label); 5482 __ j(below, false_label);
5477 __ CmpInstanceType(input, LAST_NONCALLABLE_SPEC_OBJECT_TYPE); 5483 __ CmpInstanceType(input, LAST_NONCALLABLE_SPEC_OBJECT_TYPE);
5478 __ j(above, false_label); 5484 __ j(above, false_label);
5479 // Check for undetectable objects => false. 5485 // Check for undetectable objects => false.
5480 __ testb(FieldOperand(input, Map::kBitFieldOffset), 5486 __ testb(FieldOperand(input, Map::kBitFieldOffset),
5481 Immediate(1 << Map::kIsUndetectable)); 5487 Immediate(1 << Map::kIsUndetectable));
5482 final_branch_condition = zero; 5488 final_branch_condition = zero;
5483 5489
5484 } else { 5490 } else {
5485 __ jmp(false_label); 5491 __ jmp(false_label);
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
5742 FixedArray::kHeaderSize - kPointerSize)); 5748 FixedArray::kHeaderSize - kPointerSize));
5743 __ bind(&done); 5749 __ bind(&done);
5744 } 5750 }
5745 5751
5746 5752
5747 #undef __ 5753 #undef __
5748 5754
5749 } } // namespace v8::internal 5755 } } // namespace v8::internal
5750 5756
5751 #endif // V8_TARGET_ARCH_X64 5757 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698