Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 12296026: ES6 symbols: Implement Symbol intrinsic and basic functionality (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed more comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2420 matching lines...) Expand 10 before | Expand all | Expand 10 after
2431 CheckPrototypes( 2431 CheckPrototypes(
2432 Handle<JSObject>(JSObject::cast(object->GetPrototype())), 2432 Handle<JSObject>(JSObject::cast(object->GetPrototype())),
2433 eax, holder, ebx, edx, edi, name, &miss); 2433 eax, holder, ebx, edx, edi, name, &miss);
2434 } else { 2434 } else {
2435 // Calling non-strict non-builtins with a value as the receiver 2435 // Calling non-strict non-builtins with a value as the receiver
2436 // requires boxing. 2436 // requires boxing.
2437 __ jmp(&miss); 2437 __ jmp(&miss);
2438 } 2438 }
2439 break; 2439 break;
2440 2440
2441 case SYMBOL_CHECK:
2442 // Check that the object is a symbol.
2443 __ CmpObjectType(edx, SYMBOL_TYPE, eax);
2444 __ j(not_equal, &miss);
2445 break;
2446
2441 case NUMBER_CHECK: 2447 case NUMBER_CHECK:
2442 if (function->IsBuiltin() || !function->shared()->is_classic_mode()) { 2448 if (function->IsBuiltin() || !function->shared()->is_classic_mode()) {
2443 Label fast; 2449 Label fast;
2444 // Check that the object is a smi or a heap number. 2450 // Check that the object is a smi or a heap number.
2445 __ JumpIfSmi(edx, &fast); 2451 __ JumpIfSmi(edx, &fast);
2446 __ CmpObjectType(edx, HEAP_NUMBER_TYPE, eax); 2452 __ CmpObjectType(edx, HEAP_NUMBER_TYPE, eax);
2447 __ j(not_equal, &miss); 2453 __ j(not_equal, &miss);
2448 __ bind(&fast); 2454 __ bind(&fast);
2449 // Check that the maps starting from the prototype haven't changed. 2455 // Check that the maps starting from the prototype haven't changed.
2450 GenerateDirectLoadGlobalFunctionPrototype( 2456 GenerateDirectLoadGlobalFunctionPrototype(
(...skipping 1466 matching lines...) Expand 10 before | Expand all | Expand 10 after
3917 __ jmp(ic_slow, RelocInfo::CODE_TARGET); 3923 __ jmp(ic_slow, RelocInfo::CODE_TARGET);
3918 } 3924 }
3919 } 3925 }
3920 3926
3921 3927
3922 #undef __ 3928 #undef __
3923 3929
3924 } } // namespace v8::internal 3930 } } // namespace v8::internal
3925 3931
3926 #endif // V8_TARGET_ARCH_IA32 3932 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698