Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 12296026: ES6 symbols: Implement Symbol intrinsic and basic functionality (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed more comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5885 matching lines...) Expand 10 before | Expand all | Expand 10 after
5896 __ j(equal, true_label); 5896 __ j(equal, true_label);
5897 __ CmpInstanceType(input, JS_FUNCTION_PROXY_TYPE); 5897 __ CmpInstanceType(input, JS_FUNCTION_PROXY_TYPE);
5898 final_branch_condition = equal; 5898 final_branch_condition = equal;
5899 5899
5900 } else if (type_name->Equals(heap()->object_string())) { 5900 } else if (type_name->Equals(heap()->object_string())) {
5901 __ JumpIfSmi(input, false_label); 5901 __ JumpIfSmi(input, false_label);
5902 if (!FLAG_harmony_typeof) { 5902 if (!FLAG_harmony_typeof) {
5903 __ cmp(input, factory()->null_value()); 5903 __ cmp(input, factory()->null_value());
5904 __ j(equal, true_label); 5904 __ j(equal, true_label);
5905 } 5905 }
5906 __ CmpObjectType(input, FIRST_NONCALLABLE_SPEC_OBJECT_TYPE, input); 5906 if (FLAG_harmony_symbols) {
5907 __ CmpObjectType(input, SYMBOL_TYPE, input);
5908 __ j(equal, true_label);
5909 __ CmpInstanceType(input, FIRST_NONCALLABLE_SPEC_OBJECT_TYPE);
5910 } else {
5911 __ CmpObjectType(input, FIRST_NONCALLABLE_SPEC_OBJECT_TYPE, input);
5912 }
5907 __ j(below, false_label); 5913 __ j(below, false_label);
5908 __ CmpInstanceType(input, LAST_NONCALLABLE_SPEC_OBJECT_TYPE); 5914 __ CmpInstanceType(input, LAST_NONCALLABLE_SPEC_OBJECT_TYPE);
5909 __ j(above, false_label); 5915 __ j(above, false_label);
5910 // Check for undetectable objects => false. 5916 // Check for undetectable objects => false.
5911 __ test_b(FieldOperand(input, Map::kBitFieldOffset), 5917 __ test_b(FieldOperand(input, Map::kBitFieldOffset),
5912 1 << Map::kIsUndetectable); 5918 1 << Map::kIsUndetectable);
5913 final_branch_condition = zero; 5919 final_branch_condition = zero;
5914 5920
5915 } else { 5921 } else {
5916 __ jmp(false_label); 5922 __ jmp(false_label);
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
6178 FixedArray::kHeaderSize - kPointerSize)); 6184 FixedArray::kHeaderSize - kPointerSize));
6179 __ bind(&done); 6185 __ bind(&done);
6180 } 6186 }
6181 6187
6182 6188
6183 #undef __ 6189 #undef __
6184 6190
6185 } } // namespace v8::internal 6191 } } // namespace v8::internal
6186 6192
6187 #endif // V8_TARGET_ARCH_IA32 6193 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698