Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 12296026: ES6 symbols: Implement Symbol intrinsic and basic functionality (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed more comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6020 matching lines...) Expand 10 before | Expand all | Expand 10 after
6031 __ b(eq, true_label); 6031 __ b(eq, true_label);
6032 __ cmp(input, Operand(JS_FUNCTION_PROXY_TYPE)); 6032 __ cmp(input, Operand(JS_FUNCTION_PROXY_TYPE));
6033 final_branch_condition = eq; 6033 final_branch_condition = eq;
6034 6034
6035 } else if (type_name->Equals(heap()->object_string())) { 6035 } else if (type_name->Equals(heap()->object_string())) {
6036 __ JumpIfSmi(input, false_label); 6036 __ JumpIfSmi(input, false_label);
6037 if (!FLAG_harmony_typeof) { 6037 if (!FLAG_harmony_typeof) {
6038 __ CompareRoot(input, Heap::kNullValueRootIndex); 6038 __ CompareRoot(input, Heap::kNullValueRootIndex);
6039 __ b(eq, true_label); 6039 __ b(eq, true_label);
6040 } 6040 }
6041 __ CompareObjectType(input, input, scratch, 6041 if (FLAG_harmony_symbols) {
6042 FIRST_NONCALLABLE_SPEC_OBJECT_TYPE); 6042 __ CompareObjectType(input, input, scratch, SYMBOL_TYPE);
6043 __ b(eq, true_label);
6044 __ CompareInstanceType(input, scratch,
6045 FIRST_NONCALLABLE_SPEC_OBJECT_TYPE);
6046 } else {
6047 __ CompareObjectType(input, input, scratch,
6048 FIRST_NONCALLABLE_SPEC_OBJECT_TYPE);
6049 }
6043 __ b(lt, false_label); 6050 __ b(lt, false_label);
6044 __ CompareInstanceType(input, scratch, LAST_NONCALLABLE_SPEC_OBJECT_TYPE); 6051 __ CompareInstanceType(input, scratch, LAST_NONCALLABLE_SPEC_OBJECT_TYPE);
6045 __ b(gt, false_label); 6052 __ b(gt, false_label);
6046 // Check for undetectable objects => false. 6053 // Check for undetectable objects => false.
6047 __ ldrb(ip, FieldMemOperand(input, Map::kBitFieldOffset)); 6054 __ ldrb(ip, FieldMemOperand(input, Map::kBitFieldOffset));
6048 __ tst(ip, Operand(1 << Map::kIsUndetectable)); 6055 __ tst(ip, Operand(1 << Map::kIsUndetectable));
6049 final_branch_condition = eq; 6056 final_branch_condition = eq;
6050 6057
6051 } else { 6058 } else {
6052 __ b(false_label); 6059 __ b(false_label);
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
6316 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize)); 6323 __ sub(scratch, result, Operand(index, LSL, kPointerSizeLog2 - kSmiTagSize));
6317 __ ldr(result, FieldMemOperand(scratch, 6324 __ ldr(result, FieldMemOperand(scratch,
6318 FixedArray::kHeaderSize - kPointerSize)); 6325 FixedArray::kHeaderSize - kPointerSize));
6319 __ bind(&done); 6326 __ bind(&done);
6320 } 6327 }
6321 6328
6322 6329
6323 #undef __ 6330 #undef __
6324 6331
6325 } } // namespace v8::internal 6332 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698