Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12296007: [content shell] hook up navigation related WebTestDelegate methods (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 10 months ago
Reviewers:
Charlie Reis, jam, marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] hook up navigation related WebTestDelegate methods BUG=111316 R=jam@chromium.org,marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M content/browser/web_contents/navigation_controller_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M content/shell/shell_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/shell/webkit_test_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/webkit_test_controller.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
7 years, 10 months ago (2013-02-18 12:52:58 UTC) #1
jochen (gone - plz use gerrit)
Please review: John: content/*/browser Marja: content/shell
7 years, 10 months ago (2013-02-18 12:53:31 UTC) #2
marja
content/shell lgtm
7 years, 10 months ago (2013-02-18 13:35:10 UTC) #3
jam
redirecting to creis, he's more familiar with that code than me (i.e. to see if ...
7 years, 10 months ago (2013-02-19 16:21:27 UTC) #4
Charlie Reis
This seems right to me. It's just hooking up the code added in https://codereview.chromium.org/12052023, and ...
7 years, 10 months ago (2013-02-19 23:35:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12296007/1
7 years, 10 months ago (2013-02-20 07:08:55 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 08:22:42 UTC) #7
Message was sent while issue was closed. 
Change committed as 183433

Powered by Google App Engine
This is Rietveld 408576698