Issue 12296004: Make test_shell build on Win64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12296004: Make test_shell build on Win64 (Closed)

Created:
7 years, 10 months ago by jschuh

Modified:
7 years, 10 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Make test_shell build on Win64 Disable c4267 warning and fix a broken call site due to a deprecated function. BUG=166496 BUG=167187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183414

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	webkit/tools/test_shell/test_shell.gypi	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
	M	webkit/tools/test_shell/webwidget_host_win.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

jschuh

PTAL. Should just be a rubberstamp, but I don't want to TBR since it's not ...

7 years, 10 months ago (2013-02-17 16:51:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/12296004/3002

7 years, 10 months ago (2013-02-20 01:58:35 UTC) #3

jschuh

7 years, 10 months ago (2013-02-20 05:03:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r183414 (presubmit successful).