cc: Simplify and rename MainThreadIsInHighLatency logic

cc: Simplify and rename MainThreadIsInHighLatency logic

Instead of inferring if the main thread is in a high latency
mode or not based on many other variables, track it
explicitly at the end of the BeginImplFrame deadline.

Also rename MainThreadIsHighLatency to
main_thread_missed_last_deadline so it's clearer what
that variable means exactly.

BUG=406158
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/fa55c285c4aa5a05ecfc157b340b4bb8117c5c57
Cr-Commit-Position: refs/heads/master@{#339695}

[brianderson, 2015-07-08 01:00:05]

brianderson@chromium.org changed reviewers:
+ mithro@mithis.com, sunnyps@chromium.org

[brianderson, 2015-07-08 01:00:06]

wdyt?

[mithro-old, 2015-07-08 03:06:22]

LGTM. I think this makes a lot of sense.

How does it effect the tests?

I think the "main thread is high latency" is really a bad name. It should be
something like "main_thread_missed_last_deadline_" or something more
descriptive.

[brianderson, 2015-07-09 21:44:25]

All tests pass without modification. I updated the naming too.

[mithro-old, 2015-07-13 01:25:13]

Still LGTM :)

[sunnyps, 2015-07-13 20:03:09]

LGTM

https://codereview.chromium.org/1229573004/diff/20001/cc/scheduler/scheduler_...
File cc/scheduler/scheduler_state_machine.cc (right):

https://codereview.chromium.org/1229573004/diff/20001/cc/scheduler/scheduler_...
cc/scheduler/scheduler_state_machine.cc:1125: main_thread_missed_last_deadline_
= false;
It looks like we need to set main_thread_missed_last_deadline_ to false whenever
NeedsBeginFrames goes from false to true. I need to do something similar in an
upcoming CL for a webview bug.

[mithro-old, 2015-07-20 07:24:13]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2015-07-20 07:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 07:24:18]

This CL has an open dependency (Issue 1203203003 Patch 40001). Please resolve
the dependency and try again.

[mithro-old, 2015-07-20 07:24:26]

The CQ bit was unchecked by mithro@mithis.com

[mithro-old, 2015-07-20 07:24:39]

The CQ bit was checked by mithro@mithis.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 07:24:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229573004/20001

[commit-bot: I haz the power, 2015-07-20 07:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 07:26:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brianderson, 2015-07-20 23:17:09]

The CQ bit was checked by brianderson@chromium.org

[brianderson, 2015-07-20 23:17:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
sunnyps@chromium.org, mithro@mithis.com
Link to the patchset: https://codereview.chromium.org/1229573004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-07-20 23:17:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229573004/40001

[commit-bot: I haz the power, 2015-07-20 23:40:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 23:40:30]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_arm_compile on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compi...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brianderson, 2015-07-21 17:07:17]

The CQ bit was checked by brianderson@chromium.org

[commit-bot: I haz the power, 2015-07-21 17:07:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229573004/40001

[commit-bot: I haz the power, 2015-07-21 18:07:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-21 18:08:31]

Patchset 3 (id:??) landed as
https://crrev.com/fa55c285c4aa5a05ecfc157b340b4bb8117c5c57
Cr-Commit-Position: refs/heads/master@{#339695}