Stop delay loading user32.dll from chrome.dll on x86/Windows.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 2199 matching lines @@
           'VCLinkerTool': {
             'AdditionalDependencies': [
               'kernel32.lib',
               'gdi32.lib',
               'winspool.lib',
               'comdlg32.lib',
               'advapi32.lib',
               'shell32.lib',
               'ole32.lib',
               'oleaut32.lib',
-              'user32.lib',
               'uuid.lib',
               'odbc32.lib',
               'odbccp32.lib',
               'delayimp.lib',
             ],
           },
         },
       },
       'x86_Base': {
         'abstract': 1,
@@ skipping 77 matching lines @@
             'LinkIncremental': '<(msvs_debug_link_incremental)',
             # ASLR makes debugging with windbg difficult because Chrome.exe and
             # Chrome.dll share the same base name. As result, windbg will
             # name the Chrome.dll module like chrome_<base address>, where
             # <base address> typically changes with each launch. This in turn
             # means that breakpoints in Chrome.dll don't stick from one launch
             # to the next. For this reason, we turn ASLR off in debug builds.
             # Note that this is a three-way bool, where 0 means to pick up
             # the default setting, 1 is off and 2 is on.
             'RandomizedBaseAddress': 1,
+            # In debug builds we link with the Platform SDK user32.dll import
+            # library.
+            'AdditionalDependencies': [ 'user32.lib' ],
           },
           'VCResourceCompilerTool': {
             'PreprocessorDefinitions': ['_DEBUG'],
           },
         },
         'conditions': [
           ['OS=="linux" or OS=="android"', {
             'target_conditions': [
               ['_toolset=="target"', {
                 'cflags': [
@@ skipping 1676 matching lines @@
           'x86_Base': {
             'msvs_settings': {
               'VCLinkerTool': {
                 'AdditionalOptions': [
                   '/safeseh',
                   '/dynamicbase',
                   '/ignore:4199',
                   '/ignore:4221',
                   '/nxcompat',
                 ],
+                'AdditionalLibraryDirectories': [
+                  '<(DEPTH)/build/win/importlibs/x86',
+                ],
+                # Link against the XP-constrained user32 import library to avoid
+                # inadvertently taking dependencies on post-XP user32 exports.
+                'AdditionalDependencies': [
+                  'user32.winxp.lib',
+                ],
+                'IgnoreDefaultLibraryNames': [
+                  'user32.lib',
+                ],
               },
             },
           },
           'x64_Base': {
             'msvs_settings': {
               'VCLinkerTool': {
                 'AdditionalOptions': [
                   # safeseh is not compatible with x64
                   '/dynamicbase',
                   '/ignore:4199',
                   '/ignore:4221',
                   '/nxcompat',
                 ],
+                'AdditionalLibraryDirectories': [
+                  '<(DEPTH)/build/win/importlibs/x64',
+                ],
+                # On X64 we link against the SDK's user32 import library.
+                # TODO(siggi): the right thing to do here is probably to
+                #     link against the Vista-level X64 import library.

[M-A Ruel, 2013/03/03 01:48:02]

I'd prefer to not break the 5 Win2k3 users once chrome x64 gets out.

[Sigurður Ásgeirsson, 2013/03/25 20:43:29]

I've reduced the patch in scope to only affect chrome.dll on x86.

+                'AdditionalDependencies': [
+                  'user32.lib',
+                ],
               },
             },
           },
         },
       },
     }],
     ['enable_new_npdevice_api==1', {
       'target_defaults': {
         'defines': [
           'ENABLE_NEW_NPDEVICE_API',
@@ skipping 98 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }