sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart - Issue 12295014: Remove deprecated Strings class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart

Issue 12295014: Remove deprecated Strings class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart

diff --git a/sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart b/sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart

index 79a9aa64dfcaba0a2e6569477854b6bd132accc1..59e14b5246d330ba774c3436bca3bcb227cb4570 100644

--- a/sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart

+++ b/sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart

@@ -68,7 +68,7 @@ List<Mirror> orderByName(Iterable<Mirror> list) {

String joinWithCommas(List<String> items, [String conjunction = 'and']) {

if (items.length == 1) return items[0];

if (items.length == 2) return "${items[0]} $conjunction ${items[1]}";

- return '${Strings.join(items.getRange(0, items.length - 1), ', ')}'

+ return '${items.getRange(0, items.length - 1).join(', ')}'

', $conjunction ${items[items.length - 1]}';

}