Remove deprecated Strings class.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 89 matching lines @@
   /** The actual command line that will be executed. */
   String commandLine;
 
   Command(this.executable, this.arguments, [this.environment = null]) {
     if (io.Platform.operatingSystem == 'windows') {
       // Windows can't handle the first command if it is a .bat file or the like
       // with the slashes going the other direction.
       // TODO(efortuna): Remove this when fixed (Issue 1306).
       executable = executable.replaceAll('/', '\\');
     }
-    commandLine = "$executable ${Strings.join(arguments, ' ')}";
+    commandLine = "$executable ${arguments.join(' ')}";
   }
 
   String toString() => commandLine;
 
   Future<bool> get outputIsUpToDate => new Future.immediate(false);
   io.Path get expectedOutputFile => null;
   bool get isPixelTest => false;
 }
 
 class CompilationCommand extends Command {
@@ skipping 68 matching lines @@
               _getArguments(options, htmlFile),
               _getEnvironment(dartFlags));
 
   static Map _getEnvironment(List<String> dartFlags) {
     var needDartFlags = dartFlags != null && dartFlags.length > 0;
 
     var env = null;
     if (needDartFlags) {
       env = new Map.from(io.Platform.environment);
       if (needDartFlags) {
-        env['DART_FLAGS'] = Strings.join(dartFlags, " ");
+        env['DART_FLAGS'] = dartFlags.join(" ");
       }
     }
 
     return env;
   }
 
   static List<String> _getArguments(List<String> options, String htmlFile) {
     var arguments = new List.from(options);
     arguments.add(htmlFile);
     return arguments;
@@ skipping 88 matching lines @@
         var suffixSplit = suffix.split(' ');
         suffixSplit.forEach((e) {
           if (!e.isEmpty) newArguments.add(e);
         });
 
         newArguments.addAll(c.arguments);
         final newCommand = new Command(newExecutablePath, newArguments);
         newCommands.add(newCommand);
         // If there are extra spaces inside the prefix or suffix, this fails.
         String expected =
-            '$prefix ${c.executable} $suffix ${Strings.join(c.arguments, ' ')}';
+            '$prefix ${c.executable} $suffix ${c.arguments.join(' ')}';
         Expect.stringEquals(expected.trim(), newCommand.commandLine);
       }
       commands = newCommands;
     }
   }
 
   CommandOutput get lastCommandOutput {
     if (commandOutputs.length == 0) {
       throw new Exception("CommandOutputs is empty, maybe no command was run? ("
                           "displayName: '$displayName', "
@@ skipping 826 matching lines @@
       print('Error on batch runner input stream stdin');
       print('  Input line: $line');
       print('  Previous test\'s status: $_status');
       print('  Error: $err');
       throw err;
     };
     _process.stdin.write(line.charCodes);
   }
 
   String _createArgumentsLine(List<String> arguments) {
-    return Strings.join(arguments, ' ').concat('\n');
+    return arguments.join(' ').concat('\n');
   }
 
   void _reportResult() {
     if (!active) return;
     // _status == '>>> TEST {PASS, FAIL, OK, CRASH, FAIL, TIMEOUT}'
 
     var outcome = _status.split(" ")[2];
     var exitCode = 0;
     if (outcome == "CRASH") exitCode = CRASHING_BROWSER_EXITCODE;
     if (outcome == "FAIL" || outcome == "TIMEOUT") exitCode = 1;
@@ skipping 114 matching lines @@
   _startProcess(callback) {
     Future processFuture = io.Process.start(_executable, _batchArguments);
     processFuture.then((io.Process p) {
       _process = p;
       _stdoutStream = new io.StringInputStream(_process.stdout);
       _stderrStream = new io.StringInputStream(_process.stderr);
       _process.onExit = makeExitHandler(">>> TEST CRASH");
       callback();
     }).catchError((e) {
       print("Process error:");
-      print("  Command: $_executable ${Strings.join(_batchArguments, ' ')}");
+      print("  Command: $_executable ${_batchArguments.join(' ')}");
       print("  Error: $e");
       // If there is an error starting a batch process, chances are that
       // it will always fail. So rather than re-trying a 1000+ times, we
       // exit.
       exit(1);
       return true;
     });
   }
 }
 
@@ skipping 156 matching lines @@
               resumeTesting();
             }
             line = stdoutStringStream.readLine();
           }
           if (!_isSeleniumAvailable) {
             _startSeleniumServer();
           }
         };
       }).catchError((e) {
         print("Error starting process:");
-        print("  Command: $cmd ${Strings.join(arg, ' ')}");
+        print("  Command: $cmd ${arg.join(' ')}");
         print("  Error: $e");
         // TODO(ahe): How to report this as a test failure?
         exit(1);
         return true;
       });
     }
   }
 
   void _runTest(TestCase test) {
     if (test.usesWebDriver) {
@@ skipping 95 matching lines @@
     }
     throw new Exception('Unable to find inactive batch runner.');
   }
 
   void _tryRunTest() {
     _checkDone();
     if (_numProcesses < _maxProcesses && !_tests.isEmpty) {
       TestCase test = _tests.removeFirst();
       if (_listTests) {
         var fields = [test.displayName,
-                      Strings.join(new List.from(test.expectedOutcomes), ','),
+                      test.expectedOutcomes.join(','),
                       test.isNegative.toString()];
         fields.addAll(test.commands.last.arguments);
-        print(Strings.join(fields, '\t'));
+        print(fields.join('\t'));
         return;
       }
       if (test.usesWebDriver && _needsSelenium && !_isSeleniumAvailable || (test
           is BrowserTestCase && test.waitingForOtherTest)) {
         // The test is not yet ready to run. Put the test back in
         // the queue.  Avoid spin-polling by using a timeout.
         _tests.add(test);
         new Timer(100, (_) => _tryRunTest());  // Don't lose a process.
         return;
       }
@@ skipping 154 matching lines @@
           completer.complete(testCase);
         }
       });
     }
     runCommand();
 
     return completer.future;
   }
 }