Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 122943005: [NaCl SDK] Change KernelProxy::GetCWD() to allocate path. (Closed)

Created:
6 years, 11 months ago by Matthew Turk
Modified:
6 years, 11 months ago
Reviewers:
noelallen1, binji, Sam Clegg
CC:
chromium-reviews, binji, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[NaCl SDK] Change KernelProxy::GetCWD() to allocate path. When supplying a zero size to getcwd() typical behavior is to allocate internally and return a pointer. This behavior was already implemented, but disabled by checking if size <= 0 and erroring with EINVAL. As size_t is positive definite, this entire check can be removed. R=noelallen@chromium.org, sbc@chromium.org, binji@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244213

Patch Set 1 #

Patch Set 2 : [NaCl SDK] Change KernelProxy::GetCWD() to allocate path. #

Patch Set 3 : Adding my name to root AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Matthew Turk
6 years, 11 months ago (2014-01-03 17:50:28 UTC) #1
binji
lgtm, thanks! Please add your name to the native_client_sdk/src/AUTHORS file, and make sure you've signed ...
6 years, 11 months ago (2014-01-03 18:30:21 UTC) #2
Matthew Turk
On 2014/01/03 18:30:21, binji wrote: > lgtm, thanks! > > Please add your name to ...
6 years, 11 months ago (2014-01-03 18:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewturk@gmail.com/122943005/60001
6 years, 11 months ago (2014-01-08 18:34:37 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43850
6 years, 11 months ago (2014-01-08 18:57:08 UTC) #5
Matthew Turk
On 2014/01/08 18:57:08, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 11 months ago (2014-01-08 19:12:43 UTC) #6
Sam Clegg
lgtm
6 years, 11 months ago (2014-01-10 17:13:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/matthewturk@gmail.com/122943005/210001
6 years, 11 months ago (2014-01-10 17:18:28 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 19:14:55 UTC) #9
Message was sent while issue was closed.
Change committed as 244213

Powered by Google App Engine
This is Rietveld 408576698