Issue 122943004: Convert two more tests to DEF_TEST() macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122943004: Convert two more tests to DEF_TEST() macro. (Closed)

Created:
6 years, 11 months ago by tfarina

Modified:
6 years, 11 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Convert two more tests to DEF_TEST() macro. Out of three, two were converted. These tests were found with the following command line: $ g grep "public Test" BUG=None TEST=ran tests executable fine. R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=12905

Patch Set 1 #

Patch Set 2 : ARGBImageEncoderTest.cpp too #

Total comments: 2

Patch Set 3 : fix typo #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -65 lines)			Patch
	M	tests/ARGBImageEncoderTest.cpp	View	1 2	2 chunks	+6 lines, -20 lines	0 comments	Download
	M	tests/BitmapHasherTest.cpp	View		1 chunk	+28 lines, -45 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

I left tests/ChecksumTest.cpp for a follow up, it is a bit more complicated than the ...

6 years, 11 months ago (2014-01-02 22:42:57 UTC) #1

mtklein

lgtm https://codereview.chromium.org/122943004/diff/30001/tests/ARGBImageEncoderTest.cpp File tests/ARGBImageEncoderTest.cpp (right): https://codereview.chromium.org/122943004/diff/30001/tests/ARGBImageEncoderTest.cpp#newcode21 tests/ARGBImageEncoderTest.cpp:21: DEF_TEST(ARGBImageEncodere, reporter) { Stray 'e' at the end ...

6 years, 11 months ago (2014-01-02 22:54:44 UTC) #2

tfarina

https://codereview.chromium.org/122943004/diff/30001/tests/ARGBImageEncoderTest.cpp File tests/ARGBImageEncoderTest.cpp (right): https://codereview.chromium.org/122943004/diff/30001/tests/ARGBImageEncoderTest.cpp#newcode21 tests/ARGBImageEncoderTest.cpp:21: DEF_TEST(ARGBImageEncodere, reporter) { On 2014/01/02 22:54:44, mtklein wrote: > ...

6 years, 11 months ago (2014-01-02 23:00:54 UTC) #3

tfarina

6 years, 11 months ago (2014-01-06 12:44:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r12905 (presubmit successful).

Expand Messages | Collapse Messages