Source/core/rendering/RenderLayer.cpp - Issue 122943003: Make calls to AtomicString(const String&) explicit in rendering/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 122943003: Make calls to AtomicString(const String&) explicit in rendering/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/HitTestResult.cpp ('k') | Source/core/rendering/RenderLayerFilterInfo.cpp » ('j') | Source/core/rendering/RenderThemeChromiumFontProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index bba59c16c35db7c94cd472514116501847df8a5b..ca657770c681d88c0836a817177405be6786cc44 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -2041,7 +2041,7 @@ void RenderLayer::paintLayerContents(GraphicsContext* context, const LayerPainti

ReferenceClipPathOperation* referenceClipPathOperation = toReferenceClipPathOperation(style->clipPath());

Document& document = renderer()->document();

// FIXME: It doesn't work with forward or external SVG references (https://bugs.webkit.org/show_bug.cgi?id=90405)

- Element* element = document.getElementById(referenceClipPathOperation->fragment());

+ Element* element = document.getElementById(AtomicString(referenceClipPathOperation->fragment()));

if (element && element->hasTagName(SVGNames::clipPathTag) && element->renderer()) {

if (!rootRelativeBoundsComputed) {

rootRelativeBounds = calculateLayerBounds(paintingInfo.rootLayer, &offsetFromRoot, 0);