Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: Source/core/rendering/RenderThemeChromiumFontProvider.cpp

Issue 122943003: Make calls to AtomicString(const String&) explicit in rendering/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderThemeChromiumFontProvider.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...) Expand all
39 39
40 // We aim to match IE here. 40 // We aim to match IE here.
41 // -IE uses a font based on the encoding as the default font for form controls. 41 // -IE uses a font based on the encoding as the default font for form controls.
42 // -Gecko uses MS Shell Dlg (actually calls GetStockObject(DEFAULT_GUI_FONT), 42 // -Gecko uses MS Shell Dlg (actually calls GetStockObject(DEFAULT_GUI_FONT),
43 // which returns MS Shell Dlg) 43 // which returns MS Shell Dlg)
44 // -Safari uses Lucida Grande. 44 // -Safari uses Lucida Grande.
45 // 45 //
46 // FIXME: The only case where we know we don't match IE is for ANSI encodings. 46 // FIXME: The only case where we know we don't match IE is for ANSI encodings.
47 // IE uses MS Shell Dlg there, which we render incorrectly at certain pixel 47 // IE uses MS Shell Dlg there, which we render incorrectly at certain pixel
48 // sizes (e.g. 15px). So, for now we just use Arial. 48 // sizes (e.g. 15px). So, for now we just use Arial.
49 const String& RenderThemeChromiumFontProvider::defaultGUIFont() 49 const AtomicString& RenderThemeChromiumFontProvider::defaultGUIFont()
50 { 50 {
51 DEFINE_STATIC_LOCAL(String, fontFace, ("Arial")); 51 DEFINE_STATIC_LOCAL(const AtomicString, fontFace, ("Arial", AtomicString::Co nstructFromLiteral));
52 return fontFace; 52 return fontFace;
53 } 53 }
54 54
55 } // namespace WebCore 55 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderThemeChromiumFontProvider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698