Source/core/rendering/RenderThemeChromiumFontProvider.h - Issue 122943003: Make calls to AtomicString(const String&) explicit in rendering/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/rendering/RenderThemeChromiumFontProvider.h

Issue 122943003: Make calls to AtomicString(const String&) explicit in rendering/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 24 matching lines...) Expand all Loading...
35 namespace WebCore {	35 namespace WebCore {

36	36

37 class FontDescription;	37 class FontDescription;

38	38

39 class RenderThemeChromiumFontProvider {	39 class RenderThemeChromiumFontProvider {

40 public:	40 public:

41 static void systemFont(CSSValueID, FontDescription&);	41 static void systemFont(CSSValueID, FontDescription&);

42 static void setDefaultFontSize(int);	42 static void setDefaultFontSize(int);

43	43

44 protected:	44 protected:

45 static const WTF::String& defaultGUIFont();	45 static const WTF::AtomicString& defaultGUIFont();
	Inactive 2013/12/31 21:35:43 All callers expect an AtomicString: Source/core/re All callers expect an AtomicString: Source/core/rendering/RenderThemeChromiumFontProviderLinux.cpp: fontDescription.firstFamily().setFamily(defaultGUIFont()); Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp: faceName = defaultGUIFont();
46	46

47 static float s_defaultFontSize;	47 static float s_defaultFontSize;

48 };	48 };

49	49

50 } // namespace WebCore	50 } // namespace WebCore

51	51

52 #endif // RenderThemeChromiumFontProvider_h	52 #endif // RenderThemeChromiumFontProvider_h

OLD	NEW

« no previous file with comments | « Source/core/rendering/RenderLayerFilterInfo.cpp ('k') | Source/core/rendering/RenderThemeChromiumFontProvider.cpp » ('j') | no next file with comments »