Source/platform/fonts/Font.cpp - Issue 1229413005: Reland of land "Change fallback font collection in HarfBuzzShaper"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.cpp

Issue 1229413005: Reland of land "Change fallback font collection in HarfBuzzShaper" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/Font.cpp

diff --git a/Source/platform/fonts/Font.cpp b/Source/platform/fonts/Font.cpp

index fcf0d6448827e7020f7a94cd709879e699c2c9b5..5ee5e3bc2178439359efe0f6f685a9d759e1423a 100644

--- a/Source/platform/fonts/Font.cpp

+++ b/Source/platform/fonts/Font.cpp

@@ -707,8 +707,7 @@

int Font::offsetForPositionForComplexText(const TextRun& run, float xFloat,

bool includePartialGlyphs) const

{

- HashSet<const SimpleFontData*> fallbackFonts;

- HarfBuzzShaper shaper(this, run, &fallbackFonts);

+ HarfBuzzShaper shaper(this, run);

RefPtr<ShapeResult> shapeResult = shaper.shapeResult();

if (!shapeResult)

return 0;

« no previous file with comments | « no previous file | Source/platform/fonts/shaping/CachingWordShapeIterator.h » ('j') | no next file with comments »