Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1229403003: Roll PDFium d1b0a8d:cc8b4d8 (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Tom Sepez, ulan, raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll PDFium d1b0a8d:acf0647 cc8b4d8 Make v8 embedder data slot configurable 281d1d2 Flip the shut down order in tests. 5b4f57c Make ContentStreamParser members private, fix constructor bf45988 Add a null pointer check to CPDF_CalRGB::v_Load(). e3db14f Kill Func_Renderpage global function pointer, it never changes. 97dd3fe Revert "Add test case for parsing endobj keywords." by Tom Sepez - 14 hours ago 5bd88ec Add test case for parsing endobj keywords. by Tom Sepez - 15 hours ago acf0647 Add missing reinterpret_cast from void to v8::Isolate 8ccc206 Revert "Pump the v8 message loop in tests" 1c79928 Plumb in an externally created v8::Isolate 3045780 Pump the v8 message loop in tests 7592479 Move extern cmap declarations from .cpp files into new .h files. dacc22c Move FPDFAPI_FlateInit() prototype and friends to .h file 0c96176 Tighten up DEPS include rules. BUG=none R=tsepez@chromium.org,ulan@chromium.org Committed: https://crrev.com/28df6b96bf8f5614f02a315eda1d7610ef8b4532 Cr-Commit-Position: refs/heads/master@{#339014}

Patch Set 1 #

Patch Set 2 : roll #

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gin/public/gin_embedders.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pdf/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 3 4 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-14 14:16:54 UTC) #1
ulan
lgtm
5 years, 5 months ago (2015-07-14 14:35:27 UTC) #2
Tom Sepez
Thanks. The final CL will have a DEPS roll as part of it to pull ...
5 years, 5 months ago (2015-07-14 16:32:02 UTC) #3
jochen (gone - plz use gerrit)
right, this will depend on the roll
5 years, 5 months ago (2015-07-14 18:19:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229403003/40001
5 years, 5 months ago (2015-07-15 13:26:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/78919)
5 years, 5 months ago (2015-07-15 13:32:47 UTC) #9
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-07-15 13:46:38 UTC) #11
raymes
rubberstam lgtm
5 years, 5 months ago (2015-07-16 00:34:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229403003/60001
5 years, 5 months ago (2015-07-16 10:57:06 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-16 11:30:52 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 11:31:49 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/28df6b96bf8f5614f02a315eda1d7610ef8b4532
Cr-Commit-Position: refs/heads/master@{#339014}

Powered by Google App Engine
This is Rietveld 408576698