Linux: adjust include path for system jsoncpp.

Linux: adjust include path for system jsoncpp.

This makes it consistent with convention on Debian, Ubuntu,
Arch, and Gentoo (after https://bugs.gentoo.org/show_bug.cgi?id=452234
gets fixed).

R=ronghuawu
TBR=darin

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183190

[Ronghua Wu (Left Chromium), 2013-02-18 17:45:13]

lgtm

[commit-bot: I haz the power, 2013-02-18 21:21:16]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Paweł Hajdan Jr., 2013-02-19 10:01:22]

TBR (Darin just for third_party OWNERS, trivial change)

[tommi (sloooow) - chröme, 2013-02-19 10:30:48]

https://codereview.chromium.org/12294017/diff/1/third_party/jsoncpp/jsoncpp.gyp
File third_party/jsoncpp/jsoncpp.gyp (right):

https://codereview.chromium.org/12294017/diff/1/third_party/jsoncpp/jsoncpp.g...
third_party/jsoncpp/jsoncpp.gyp:71: '/usr/include/jsoncpp',
Would it make sense to have an OS check before adding this path?

[Paweł Hajdan Jr., 2013-02-19 10:37:08]

https://codereview.chromium.org/12294017/diff/1/third_party/jsoncpp/jsoncpp.gyp
File third_party/jsoncpp/jsoncpp.gyp (right):

https://codereview.chromium.org/12294017/diff/1/third_party/jsoncpp/jsoncpp.g...
third_party/jsoncpp/jsoncpp.gyp:71: '/usr/include/jsoncpp',
On 2013/02/19 10:30:48, tommi wrote:
> Would it make sense to have an OS check before adding this path?

When non-unices start shipping FOSS libraries as part of the system, sure. ;)

I'm also assuming you're fully aware use_system_foo switches have never been
officially supported.

[tommi (sloooow) - chröme, 2013-02-19 10:54:27]

https://codereview.chromium.org/12294017/diff/1/third_party/jsoncpp/jsoncpp.gyp
File third_party/jsoncpp/jsoncpp.gyp (right):

https://codereview.chromium.org/12294017/diff/1/third_party/jsoncpp/jsoncpp.g...
third_party/jsoncpp/jsoncpp.gyp:71: '/usr/include/jsoncpp',
On 2013/02/19 10:37:08, Paweł Hajdan Jr. wrote:
> On 2013/02/19 10:30:48, tommi wrote:
> > Would it make sense to have an OS check before adding this path?
> 
> When non-unices start shipping FOSS libraries as part of the system, sure. ;)
> 
> I'm also assuming you're fully aware use_system_foo switches have never been
> officially supported.

Nope, I'm not aware of it.  I only stumbled across this change when looking at
build breakage on the waterfall.
Since this is an os specific include path it feels to me that an OS check should
be here (as is the case in other gypi files).

Think of it another way - if this path was
'%PROGRAMFILES%\\TheSDKPath\\Include', wouldn't that at least raise one of your
eyebrows? :)

[darin (slow to review), 2013-02-20 19:35:36]

I agree with tommi's advice.  It seems like we should have an OS check before
adding /usr/include/jsoncpp to the path.