Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 12294008: Fix more remaining FilePath -> base::FilePath. (Closed)

Created:
7 years, 10 months ago by brettw
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, stevenjb+watch_chromium.org, frankf+watch_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, oshima+watch_chromium.org, ilevy+watch_chromium.org, tfarina, sail+watch_chromium.org, Aaron Boodman, davemoore+watch_chromium.org, klundberg+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Fix more remaining FilePath -> base::FilePath. This removes the "using" in file_path.h for Mac since Mac now passes trybots with no using. It still leaves the using for Windows. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+413 lines, -408 lines) Patch
M base/base_paths_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_path.h View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_version_info_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/file_version_info_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/icu_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/mac/foundation_util_unittest.mm View 5 chunks +166 lines, -182 lines 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M base/win/shortcut_unittest.cc View 5 chunks +82 lines, -76 lines 0 comments Download
M chrome/app/breakpad_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/chrome_main_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/launcher_support/chrome_launcher_support.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/installer/util/delete_after_reboot_helper.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 18 chunks +37 lines, -37 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 9 chunks +24 lines, -24 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_dll.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_info_collector_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/keystore_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M testing/android/native_test_launcher.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/metro_registration_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
brettw
7 years, 10 months ago (2013-02-18 06:14:39 UTC) #1
TBR=sky

Powered by Google App Engine
This is Rietveld 408576698