tools/telemetry/telemetry/page_runner.py - Issue 12294002: Revert 182991

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/page_runner.py

Issue 12294002: Revert 182991 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 import codecs	4 import codecs

5 import logging	5 import logging

6 import os	6 import os

7 import time	7 import time

8 import traceback	8 import traceback

9 import urlparse	9 import urlparse

10 import random	10 import random

(...skipping 300 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
311 tab.browser.credentials.LoginNoLongerNeeded(tab, page.credentials)	311 tab.browser.credentials.LoginNoLongerNeeded(tab, page.credentials)

312 try:	312 try:

313 tab.EvaluateJavaScript("""window.chrome && chrome.benchmarking &&	313 tab.EvaluateJavaScript("""window.chrome && chrome.benchmarking &&

314 chrome.benchmarking.closeConnections()""")	314 chrome.benchmarking.closeConnections()""")

315 except Exception:	315 except Exception:

316 pass	316 pass

317	317

318 @staticmethod	318 @staticmethod

319 def AddCommandLineOptions(parser):	319 def AddCommandLineOptions(parser):

320 page_filter_module.PageFilter.AddCommandLineOptions(parser)	320 page_filter_module.PageFilter.AddCommandLineOptions(parser)

OLD	NEW