tools/telemetry/telemetry/desktop_browser_finder.py - Issue 12294002: Revert 182991

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/desktop_browser_finder.py

Issue 12294002: Revert 182991 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 """Finds desktop browsers that can be controlled by telemetry."""	4 """Finds desktop browsers that can be controlled by telemetry."""

5	5

6 import logging	6 import logging

7 import os	7 import os

8 import subprocess	8 import subprocess

9 import sys	9 import sys

10	10

(...skipping 141 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
152 chromium_app_name, False):	152 chromium_app_name, False):

153 break	153 break

154	154

155 if len(browsers) and not has_display:	155 if len(browsers) and not has_display:

156 logging.warning(	156 logging.warning(

157 'Found (%s), but you do not have a DISPLAY environment set.' %	157 'Found (%s), but you do not have a DISPLAY environment set.' %

158 ','.join([b.browser_type for b in browsers]))	158 ','.join([b.browser_type for b in browsers]))

159 return []	159 return []

160	160

161 return browsers	161 return browsers

OLD	NEW