tools/telemetry/telemetry/csv_page_benchmark_results.py - Issue 12294002: Revert 182991

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/telemetry/telemetry/csv_page_benchmark_results.py

Issue 12294002: Revert 182991 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/telemetry/telemetry/crx_id.py ('k') | tools/telemetry/telemetry/csv_page_benchmark_results_unittest.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from telemetry.page_benchmark_results import PageBenchmarkResults	4 from telemetry.page_benchmark_results import PageBenchmarkResults

5	5

6 class CsvPageBenchmarkResults(PageBenchmarkResults):	6 class CsvPageBenchmarkResults(PageBenchmarkResults):

7 def __init__(self, results_writer, output_after_every_page):	7 def __init__(self, results_writer, output_after_every_page):

8 super(CsvPageBenchmarkResults, self).__init__()	8 super(CsvPageBenchmarkResults, self).__init__()

9 self._results_writer = results_writer	9 self._results_writer = results_writer

10 self._did_output_header = False	10 self._did_output_header = False

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
72	72

73 def _OutputValuesForPage(self, page_values):	73 def _OutputValuesForPage(self, page_values):

74 row = [page_values.page.url]	74 row = [page_values.page.url]

75 for measurement_name in self._header_names_written_to_writer:	75 for measurement_name in self._header_names_written_to_writer:

76 value = page_values.FindValueByMeasurementName(measurement_name)	76 value = page_values.FindValueByMeasurementName(measurement_name)

77 if value:	77 if value:

78 row.append('%s' % value.output_value)	78 row.append('%s' % value.output_value)

79 else:	79 else:

80 row.append('-')	80 row.append('-')

81 self._results_writer.writerow(row)	81 self._results_writer.writerow(row)

OLD	NEW