tools/perf/perf_tools/page_cycler.py - Issue 12294002: Revert 182991

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/perf_tools/page_cycler.py

Issue 12294002: Revert 182991 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/perf/perf_tools/octane.py ('k') | tools/perf/perf_tools/robohornetpro.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from telemetry.core import util	4

5 from telemetry.page import multi_page_benchmark	5 from telemetry import multi_page_benchmark

	6 from telemetry import util

6	7

7 MEMORY_HISTOGRAMS = [	8 MEMORY_HISTOGRAMS = [

8 {'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent'},	9 {'name': 'V8.MemoryExternalFragmentationTotal', 'units': 'percent'},

9 {'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb'},	10 {'name': 'V8.MemoryHeapSampleTotalCommitted', 'units': 'kb'},

10 {'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb'}]	11 {'name': 'V8.MemoryHeapSampleTotalUsed', 'units': 'kb'}]

11	12

12 class PageCycler(multi_page_benchmark.MultiPageBenchmark):	13 class PageCycler(multi_page_benchmark.MultiPageBenchmark):

13 def CustomizeBrowserOptions(self, options):	14 def CustomizeBrowserOptions(self, options):

14 options.AppendExtraBrowserArg('--dom-automation')	15 options.AppendExtraBrowserArg('--dom-automation')

15 options.AppendExtraBrowserArg('--js-flags=--expose_gc')	16 options.AppendExtraBrowserArg('--js-flags=--expose_gc')

(...skipping 12 matching lines...) Expand all Loading...
28 'window.domAutomationController.getHistogram("%s")' % name)	29 'window.domAutomationController.getHistogram("%s")' % name)

29 results.Add(name, histogram['units'], data, data_type='histogram')	30 results.Add(name, histogram['units'], data, data_type='histogram')

30	31

31 def _IsNavigatedToReport():	32 def _IsNavigatedToReport():

32 return tab.GetCookieByName('__navigated_to_report') == '1'	33 return tab.GetCookieByName('__navigated_to_report') == '1'

33 util.WaitFor(_IsNavigatedToReport, 60, poll_interval=5)	34 util.WaitFor(_IsNavigatedToReport, 60, poll_interval=5)

34 timings = tab.EvaluateJavaScript('__get_timings()').split(',')	35 timings = tab.EvaluateJavaScript('__get_timings()').split(',')

35 results.Add('t', 'ms', [int(t) for t in timings], chart_name='times')	36 results.Add('t', 'ms', [int(t) for t in timings], chart_name='times')

36	37

37 # TODO(tonyg): Add version that runs with extension profile.	38 # TODO(tonyg): Add version that runs with extension profile.

OLD	NEW