Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: lib/src/barback/dependency_computer.dart

Issue 1229303004: Fix a stack overflow when loading transformers. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/dependency_computer/cycle_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/barback/dependency_computer.dart
diff --git a/lib/src/barback/dependency_computer.dart b/lib/src/barback/dependency_computer.dart
index 494b3a9d6abb1ec9371afca6300331230f516573..4134e8006e2fefe7e624f7a4d7e948c89c54759b 100644
--- a/lib/src/barback/dependency_computer.dart
+++ b/lib/src/barback/dependency_computer.dart
@@ -287,8 +287,8 @@ class _PackageDependencyComputer {
// this stored set of dependencies rather than the potentially wider
// set that would be recomputed if [transformersNeededByLibrary]
// were called anew.
- _transformersNeededByTransformers[id] =
- transformersNeededByLibrary(_package.transformerPath(id));
+ _transformersNeededByTransformers.putIfAbsent(id, () =>
+ transformersNeededByLibrary(_package.transformerPath(id)));
}
} on CycleException catch (error) {
throw error.prependStep("$packageName is transformed by $id");
« no previous file with comments | « no previous file | test/dependency_computer/cycle_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698