Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229303003: Another trivial cleanup (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : minor cleanup #

Patch Set 3 : tweaks #

Patch Set 4 : more minor #

Total comments: 3

Patch Set 5 : more cleanup #

Total comments: 1

Patch Set 6 : gyp changes #

Patch Set 7 : fix crash #

Patch Set 8 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -79 lines) Patch
M gyp/gpu.gypi View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
D include/gpu/GrFragmentStage.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
M include/gpu/GrPaint.h View 1 1 chunk +1 line, -1 line 0 comments Download
A include/gpu/GrStagedProcessor.h View 1 2 3 4 5 6 7 1 chunk +43 lines, -0 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPendingFragmentStage.h View 1 2 3 4 5 6 1 chunk +10 lines, -36 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcOptInfo.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-10 19:44:42 UTC) #2
joshualitt
On 2015/07/10 19:44:42, joshualitt wrote: > ptal pinging
5 years, 5 months ago (2015-07-13 19:00:39 UTC) #3
robertphillips
https://codereview.chromium.org/1229303003/diff/60001/include/gpu/GrStagedProcessor.h File include/gpu/GrStagedProcessor.h (right): https://codereview.chromium.org/1229303003/diff/60001/include/gpu/GrStagedProcessor.h#newcode14 include/gpu/GrStagedProcessor.h:14: /** Update comment ? // templatized based on which ...
5 years, 5 months ago (2015-07-13 19:12:29 UTC) #4
joshualitt
On 2015/07/13 19:12:29, robertphillips wrote: > https://codereview.chromium.org/1229303003/diff/60001/include/gpu/GrStagedProcessor.h > File include/gpu/GrStagedProcessor.h (right): > > https://codereview.chromium.org/1229303003/diff/60001/include/gpu/GrStagedProcessor.h#newcode14 > ...
5 years, 5 months ago (2015-07-13 19:37:24 UTC) #5
robertphillips
lgtm % gypi changes https://codereview.chromium.org/1229303003/diff/80001/gyp/gpu.gypi File gyp/gpu.gypi (right): https://codereview.chromium.org/1229303003/diff/80001/gyp/gpu.gypi#newcode24 gyp/gpu.gypi:24: '<(skia_include_path)/gpu/GrFragmentProcessor.h', Delete GrFragmentStage.h ? Add ...
5 years, 5 months ago (2015-07-13 19:54:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229303003/100001
5 years, 5 months ago (2015-07-13 19:57:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1075)
5 years, 5 months ago (2015-07-13 19:58:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229303003/100001
5 years, 5 months ago (2015-07-13 19:59:19 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/52e7657cd850f95e66eb23c6d138ee45149a1039
5 years, 5 months ago (2015-07-13 20:11:44 UTC) #14
joshualitt
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1233853004/ by joshualitt@google.com. ...
5 years, 5 months ago (2015-07-13 20:28:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229303003/140001
5 years, 5 months ago (2015-07-14 13:14:42 UTC) #20
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 18:02:49 UTC) #21
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/3df1e2163f9d7afc997dc14c440fab31277bff5c

Powered by Google App Engine
This is Rietveld 408576698