Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229303002: Fix msvs builds (Closed)

Created:
5 years, 5 months ago by msarett
Modified:
5 years, 5 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M gyp/libjpeg-turbo.gyp View 1 3 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msarett
This fixes things for me!
5 years, 5 months ago (2015-07-10 14:39:56 UTC) #2
egdaniel
lgtm
5 years, 5 months ago (2015-07-10 14:46:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229303002/1
5 years, 5 months ago (2015-07-10 14:48:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2018)
5 years, 5 months ago (2015-07-10 14:54:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229303002/40001
5 years, 5 months ago (2015-07-10 17:52:17 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 17:59:51 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/718e41dcb0ad9488d3ae041c894926224dee9d70

Powered by Google App Engine
This is Rietveld 408576698