Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 1229283002: VM: Share some stub code between isolates. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index 6da8c44a6b439f2ab33da733a3dfe88789919898..ce309fb6e0a87d4d73817d0e6584ba56d5c7d927 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -1344,9 +1344,8 @@ void StubCode::GenerateNArgsCheckInlineCacheStub(
Label stepping, done_stepping;
if (FLAG_support_debugger && !optimized) {
__ Comment("Check single stepping");
- uword single_step_address = reinterpret_cast<uword>(Isolate::Current()) +
- Isolate::single_step_offset();
- __ cmpb(Address::Absolute(single_step_address), Immediate(0));
+ __ LoadIsolate(EAX);
+ __ cmpb(Address(EAX, Isolate::single_step_offset()), Immediate(0));
__ j(NOT_EQUAL, &stepping);
__ Bind(&done_stepping);
}
@@ -1646,9 +1645,8 @@ void StubCode::GenerateZeroArgsUnoptimizedStaticCallStub(Assembler* assembler) {
// Check single stepping.
Label stepping, done_stepping;
if (FLAG_support_debugger) {
- uword single_step_address = reinterpret_cast<uword>(Isolate::Current()) +
- Isolate::single_step_offset();
- __ cmpb(Address::Absolute(single_step_address), Immediate(0));
+ __ LoadIsolate(EAX);
+ __ cmpb(Address(EAX, Isolate::single_step_offset()), Immediate(0));
__ j(NOT_EQUAL, &stepping, Assembler::kNearJump);
__ Bind(&done_stepping);
}
« no previous file with comments | « runtime/vm/stub_code.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698