Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: runtime/vm/object.cc

Issue 1229283002: VM: Share some stub code between isolates. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 8869d3583e10dcac6793ff77d238d1709a2a4bf9..c27f88c0ea42c242bb51a15c161b911c01b7cdef 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -629,6 +629,9 @@ void Object::InitOnce(Isolate* isolate) {
// isolate.
Class::NewExternalTypedDataClass(kExternalTypedDataUint8ArrayCid);
+ // Needed for object pools of VM isolate stubs.
+ Class::NewTypedDataClass(kTypedDataInt8ArrayCid);
+
// Allocate and initialize the empty_array instance.
{
uword address = heap->Allocate(Array::InstanceSize(0), Heap::kOld);
@@ -1442,7 +1445,6 @@ RawError* Object::Init(Isolate* isolate) {
// Finish the initialization by compiling the bootstrap scripts containing the
// base interfaces and the implementation of the internal classes.
- StubCode::InitBootstrapStubs(isolate);
const Error& error = Error::Handle(Bootstrap::LoadandCompileScripts());
if (!error.IsNull()) {
return error.raw();
@@ -1595,7 +1597,6 @@ RawError* Object::Init(Isolate* isolate) {
Context::New(0, Heap::kOld));
object_store->set_empty_context(context);
- StubCode::InitBootstrapStubs(isolate);
#endif // defined(DART_NO_SNAPSHOT).
return Error::null();
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698