Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: runtime/vm/assembler.cc

Issue 1229283002: VM: Share some stub code between isolates. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler.cc
diff --git a/runtime/vm/assembler.cc b/runtime/vm/assembler.cc
index f2064f824bf02d5b5304c3142ba05b45975da747..3f3e61a12d2b70e046b5d734e739b2f74d96ac10 100644
--- a/runtime/vm/assembler.cc
+++ b/runtime/vm/assembler.cc
@@ -254,8 +254,6 @@ intptr_t ObjectPoolWrapper::AddImmediate(uword imm) {
intptr_t ObjectPoolWrapper::AddObject(ObjectPool::Entry entry,
Patchability patchable) {
- // The object pool cannot be used in the vm isolate.
- ASSERT(Isolate::Current() != Dart::vm_isolate());
object_pool_.Add(entry);
if (patchable == kNotPatchable) {
// The object isn't patchable. Record the index for fast lookup.
@@ -268,7 +266,6 @@ intptr_t ObjectPoolWrapper::AddObject(ObjectPool::Entry entry,
intptr_t ObjectPoolWrapper::AddExternalLabel(const ExternalLabel* label,
Patchability patchable) {
- ASSERT(Isolate::Current() != Dart::vm_isolate());
return AddObject(ObjectPool::Entry(label->address(),
ObjectPool::kImmediate),
patchable);
@@ -277,9 +274,6 @@ intptr_t ObjectPoolWrapper::AddExternalLabel(const ExternalLabel* label,
intptr_t ObjectPoolWrapper::FindObject(ObjectPool::Entry entry,
Patchability patchable) {
- // The object pool cannot be used in the vm isolate.
- ASSERT(Isolate::Current() != Dart::vm_isolate());
-
// If the object is not patchable, check if we've already got it in the
// object pool.
if (patchable == kNotPatchable) {
@@ -306,8 +300,6 @@ intptr_t ObjectPoolWrapper::FindImmediate(uword imm) {
intptr_t ObjectPoolWrapper::FindExternalLabel(const ExternalLabel* label,
Patchability patchable) {
- // The object pool cannot be used in the vm isolate.
- ASSERT(Isolate::Current() != Dart::vm_isolate());
return FindObject(ObjectPool::Entry(label->address(),
ObjectPool::kImmediate),
patchable);
« no previous file with comments | « no previous file | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698