Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: sky/engine/core/rendering/style/RenderStyle.cpp

Issue 1229273004: Remove Animations and Transitions. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/style/RenderStyle.cpp
diff --git a/sky/engine/core/rendering/style/RenderStyle.cpp b/sky/engine/core/rendering/style/RenderStyle.cpp
index 7e20e2e6c215c3ab7bb9c5a6b273239bf23bae16..22f39640c454462d9517c5b40ad0902071ee1761 100644
--- a/sky/engine/core/rendering/style/RenderStyle.cpp
+++ b/sky/engine/core/rendering/style/RenderStyle.cpp
@@ -106,7 +106,6 @@ ALWAYS_INLINE RenderStyle::RenderStyle(DefaultStyleTag)
rareNonInheritedData.init();
rareNonInheritedData.access()->m_flexibleBox.init();
rareNonInheritedData.access()->m_transform.init();
- rareNonInheritedData.access()->m_willChange.init();
rareNonInheritedData.access()->m_filter.init();
rareInheritedData.init();
inherited.init();
@@ -284,9 +283,6 @@ StyleDifference RenderStyle::visualInvalidationDiff(const RenderStyle& other) co
// Cursors are not checked, since they will be set appropriately in response to mouse events,
// so they don't need to cause any paint invalidation or layout.
- // Animations don't need to be checked either. We always set the new style on the RenderObject, so we will get a chance to fire off
- // the resulting transition properly.
-
return diff;
}
@@ -659,20 +655,6 @@ const AtomicString& RenderStyle::textEmphasisMarkString() const
return nullAtom;
}
-CSSAnimationData& RenderStyle::accessAnimations()
-{
- if (!rareNonInheritedData.access()->m_animations)
- rareNonInheritedData.access()->m_animations = CSSAnimationData::create();
- return *rareNonInheritedData->m_animations;
-}
-
-CSSTransitionData& RenderStyle::accessTransitions()
-{
- if (!rareNonInheritedData.access()->m_transitions)
- rareNonInheritedData.access()->m_transitions = CSSTransitionData::create();
- return *rareNonInheritedData->m_transitions;
-}
-
const Font& RenderStyle::font() const { return inherited->font; }
const FontMetrics& RenderStyle::fontMetrics() const { return inherited->font.fontMetrics(); }
const FontDescription& RenderStyle::fontDescription() const { return inherited->font.fontDescription(); }
« no previous file with comments | « sky/engine/core/rendering/style/RenderStyle.h ('k') | sky/engine/core/rendering/style/StyleRareNonInheritedData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698