Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2364)

Unified Diff: Source/web/FrameLoaderClientImpl.cpp

Issue 1229263003: Add an empty boolean to WebFrameClient::didFinishDocumentLoad (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index 614a692b7d127acfe5676488cd9c9be0bb2b9dfa..d0e3d1f4ebb686a5becc7a986a2dbe0f97c28c81 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -373,10 +373,10 @@ void FrameLoaderClientImpl::dispatchDidFinishLoading(DocumentLoader* loader,
m_webFrame->client()->didFinishResourceLoad(m_webFrame, identifier);
}
-void FrameLoaderClientImpl::dispatchDidFinishDocumentLoad()
+void FrameLoaderClientImpl::dispatchDidFinishDocumentLoad(bool empty)
dcheng 2015/07/13 20:53:56 I feel like empty isn't quite descriptive enough.
Nate Chapin 2015/07/13 21:13:28 I changed the chromium-side to use the name docume
dcheng 2015/07/13 21:23:22 Yes, that seems better.
{
if (m_webFrame->client())
- m_webFrame->client()->didFinishDocumentLoad(m_webFrame);
+ m_webFrame->client()->didFinishDocumentLoad(m_webFrame, empty);
}
void FrameLoaderClientImpl::dispatchDidLoadResourceFromMemoryCache(const ResourceRequest& request, const ResourceResponse& response)

Powered by Google App Engine
This is Rietveld 408576698