Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 1229243002: Disable handle zapping on 4.5 branch (Closed)

Created:
5 years, 5 months ago by Michael Hablich
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.5
Target Ref:
refs/pending/branch-heads/4.5
Project:
v8
Visibility:
Public.

Description

Disable handle zapping on 4.5 branch BUG=chromium:318206 LOG=n TBR=jochen@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/features.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
Michael Hablich
5 years, 5 months ago (2015-07-10 08:53:00 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-10 08:53:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229243002/1
5 years, 5 months ago (2015-07-10 08:58:09 UTC) #4
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 5 months ago (2015-07-10 08:58:11 UTC) #6
Michael Hablich
5 years, 5 months ago (2015-07-10 09:00:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229243002/1
5 years, 5 months ago (2015-07-10 09:01:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 09:01:15 UTC) #10
skomski
I think this needs to be fixed because it disables handle zapping on the debug ...
5 years, 3 months ago (2015-09-07 22:23:58 UTC) #11
jochen (gone - plz use gerrit)
good catch, thank you
5 years, 3 months ago (2015-09-08 07:34:27 UTC) #12
Michael Hablich
5 years, 3 months ago (2015-09-08 07:36:29 UTC) #13
Message was sent while issue was closed.
On 2015/09/08 07:34:27, jochen wrote:
> good catch, thank you

Thanks. Fixed: https://codereview.chromium.org/1326693004/

Powered by Google App Engine
This is Rietveld 408576698