Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1229233002: Remove more uses of the deprecated EnumSet template class. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove more uses of the deprecated EnumSet template class. EnumtSet has been deprecated for quite some time, and replaced with the more general and type safe base::Flags template class. R=jarin@chromium.org Committed: https://crrev.com/331b87e222e852eb29eb70ff3d6e5942a983c940 Cr-Commit-Position: refs/heads/master@{#29564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -108 lines) Patch
M src/ast.h View 5 chunks +13 lines, -6 lines 0 comments Download
M src/ast-numbering.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M src/compiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 4 chunks +11 lines, -22 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 6 chunks +18 lines, -22 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 10 chunks +32 lines, -36 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-10 05:38:58 UTC) #1
Benedikt Meurer
Hey Jaro, Some cleanup. Please take a look. Thanks, Benedikt
5 years, 5 months ago (2015-07-10 05:39:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229233002/1
5 years, 5 months ago (2015-07-10 06:10:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 06:23:02 UTC) #6
Jarin
lgtm
5 years, 5 months ago (2015-07-10 08:30:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229233002/1
5 years, 5 months ago (2015-07-10 09:33:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 09:35:02 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 09:35:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/331b87e222e852eb29eb70ff3d6e5942a983c940
Cr-Commit-Position: refs/heads/master@{#29564}

Powered by Google App Engine
This is Rietveld 408576698