chrome/android/java/res/values/dimens.xml - Issue 1229223002: Add a footer at the bottom of the menu for custom tabs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added new interface call to chrome shell Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/powered_by_chrome_footer.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <!-- Connection info popup dimensions -->	7 <!-- Connection info popup dimensions -->

8 <dimen name="connection_info_padding_wide">24dp</dimen>	8 <dimen name="connection_info_padding_wide">24dp</dimen>

9 <dimen name="connection_info_padding_thin">16dp</dimen>	9 <dimen name="connection_info_padding_thin">16dp</dimen>

10	10

(...skipping 268 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
279 <dimen name="enhanced_bookmark_minimum_dialog_size_tablet">500dp</dimen>	279 <dimen name="enhanced_bookmark_minimum_dialog_size_tablet">500dp</dimen>

280 <dimen name="enhanced_bookmark_drawer_drawable_padding">18dp</dimen>	280 <dimen name="enhanced_bookmark_drawer_drawable_padding">18dp</dimen>

281	281

282 <!-- Custom Tabs dimensions -->	282 <!-- Custom Tabs dimensions -->

283 <dimen name="custom_tabs_toolbar_maxWidth">60dp</dimen>	283 <dimen name="custom_tabs_toolbar_maxWidth">60dp</dimen>

284 <dimen name="custom_tabs_toolbar_vertical_padding">16dp</dimen>	284 <dimen name="custom_tabs_toolbar_vertical_padding">16dp</dimen>

285 <dimen name="toolbar_icon_height">24dp</dimen>	285 <dimen name="toolbar_icon_height">24dp</dimen>

286 <dimen name="min_toolbar_icon_side_padding">6dp</dimen>	286 <dimen name="min_toolbar_icon_side_padding">6dp</dimen>

287 <dimen name="custom_tabs_url_text_size">12sp</dimen>	287 <dimen name="custom_tabs_url_text_size">12sp</dimen>

288 <dimen name="custom_tabs_title_text_size">16sp</dimen>	288 <dimen name="custom_tabs_title_text_size">16sp</dimen>

	289 <dimen name="menu_footer_height">28dp</dimen>

289 </resources>	290 </resources>

OLD	NEW