chrome/android/java/res/drawable/bg_menu_chrome_branding.xml - Issue 1229223002: Add a footer at the bottom of the menu for custom tabs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/bg_menu_chrome_branding.xml

Issue 1229223002: Add a footer at the bottom of the menu for custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <shape xmlns:android="http://schemas.android.com/apk/res/android"	6 <shape xmlns:android="http://schemas.android.com/apk/res/android"

7 android:shape="rectangle">	7 android:shape="rectangle">

8 <corners	8 <stroke

9 android:radius="2dp" />	9 android:width="1px"
	newt (away) 2015/07/10 16:08:38 1px will be almost invisible on fancy new xxhdpi a 1px will be almost invisible on fancy new xxhdpi and xxxhdpi phones. I'd probably just use 1dp. (Alternatively, you could look at how wide list dividers in various screen resolution and define a new dimen called divider_width that's, say, 1px on devices up to xhdpi, and 2px on larger devices. I think list dividers might just be 1dp, though.) Also, this will produce a border on all four sides, which is not what we want. Could you upload a screenshot on the bug? To fix that, you could a) use <inset> element with insetRight, insetLeft, and insetBottom set to "-1dp", or b) instead of using a fancy background, change chrome_branding_footer.xml to be a FrameLayout that contains a View with height 1dp, and a TextView below that. Yusuf 2015/07/10 18:43:47 Done.Opted for the less cool FrameLayout option wi Show quoted text On 2015/07/10 16:08:38, newt wrote: > 1px will be almost invisible on fancy new xxhdpi and xxxhdpi phones. I'd > probably just use 1dp. (Alternatively, you could look at how wide list dividers > in various screen resolution and define a new dimen called divider_width that's, > say, 1px on devices up to xhdpi, and 2px on larger devices. I think list > dividers might just be 1dp, though.) > > Also, this will produce a border on all four sides, which is not what we want. > Could you upload a screenshot on the bug? To fix that, you could a) use <inset> > element with insetRight, insetLeft, and insetBottom set to "-1dp", or b) instead > of using a fancy background, change chrome_branding_footer.xml to be a > FrameLayout that contains a View with height 1dp, and a TextView below that. Done.Opted for the less cool FrameLayout option with 1 dp.
	10 android:color="#E0E0E0" />

10 <solid	11 <solid

11 android:color="@android:color/white" />	12 android:color="#f5f5f5" />

12 </shape>	13 </shape>

OLD	NEW

« no previous file with comments | « no previous file | chrome/android/java/res/layout/chrome_branding_footer.xml » ('j') | chrome/android/java/res/layout/chrome_branding_footer.xml » ('J')