Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1995)

Unified Diff: chrome/browser/ui/startup/default_browser_prompt_win.cc

Issue 1229213006: Do not show the first-run default browser prompt on Win10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revised comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/default_browser_prompt_win.cc
diff --git a/chrome/browser/ui/startup/default_browser_prompt_win.cc b/chrome/browser/ui/startup/default_browser_prompt_win.cc
index 4b19c166e538dbc06b53873846f176023f8120e9..d2d01ce10c9d186de1b9c7205391c90022c0ec54 100644
--- a/chrome/browser/ui/startup/default_browser_prompt_win.cc
+++ b/chrome/browser/ui/startup/default_browser_prompt_win.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/startup/default_browser_prompt.h"
#include "base/prefs/pref_service.h"
+#include "base/win/windows_version.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/shell_integration.h"
#include "chrome/browser/ui/browser.h"
@@ -70,6 +71,11 @@ void SetMetroBrowserFlowLauncher::Observe(
namespace chrome {
bool ShowFirstRunDefaultBrowserPrompt(Profile* profile) {
+ // The behavior on Windows 10 is no good at the moment, since there is no
+ // known way to lead the user directly to a default browser picker.
+ if (base::win::GetVersion() >= base::win::VERSION_WIN10)
+ return false;
+
// If the only available mode of setting the default browser requires
// user interaction, it means this couldn't have been done yet. Therefore,
// we launch the dialog and inform the caller of it.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698