Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1229213006: Do not show the first-run default browser prompt on Win10. (Closed)

Created:
5 years, 5 months ago by grt (UTC plus 2)
Modified:
5 years, 5 months ago
Reviewers:
msw, hodie
CC:
chromium-reviews, gab, jschuh, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not show the first-run default browser prompt on Win10. BUG=508178 R=msw@chromium.org Committed: https://crrev.com/af307b6a4c9183a2cd9f2c9680273466979dc4c0 Cr-Commit-Position: refs/heads/master@{#338369}

Patch Set 1 #

Total comments: 1

Patch Set 2 : revised comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/startup/default_browser_prompt_win.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
grt (UTC plus 2)
PTAL
5 years, 5 months ago (2015-07-10 19:46:55 UTC) #1
msw
lgtm with a nit https://codereview.chromium.org/1229213006/diff/1/chrome/browser/ui/startup/default_browser_prompt_win.cc File chrome/browser/ui/startup/default_browser_prompt_win.cc (right): https://codereview.chromium.org/1229213006/diff/1/chrome/browser/ui/startup/default_browser_prompt_win.cc#newcode74 chrome/browser/ui/startup/default_browser_prompt_win.cc:74: // The behavior on Windows ...
5 years, 5 months ago (2015-07-10 19:54:03 UTC) #2
grt (UTC plus 2)
Thanks. hodie: please LGTM and check the commit box if you really want this.
5 years, 5 months ago (2015-07-10 20:38:38 UTC) #4
hodie
On 2015/07/10 20:38:38, grt wrote: > Thanks. > > hodie: please LGTM and check the ...
5 years, 5 months ago (2015-07-10 20:44:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229213006/10002
5 years, 5 months ago (2015-07-10 20:45:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:10002)
5 years, 5 months ago (2015-07-10 21:41:39 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 21:42:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af307b6a4c9183a2cd9f2c9680273466979dc4c0
Cr-Commit-Position: refs/heads/master@{#338369}

Powered by Google App Engine
This is Rietveld 408576698