sandbox/win/src/broker_services.cc - Issue 1229163002: Sandbox: Remove raw handles from PolicyBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/broker_services.cc

Issue 1229163002: Sandbox: Remove raw handles from PolicyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/broker_services.cc

diff --git a/sandbox/win/src/broker_services.cc b/sandbox/win/src/broker_services.cc

index dbf75f967ec9d82ddc7000b38ecf2020034551f5..c5a18d30e5323c5510607615117fbd6319b43a0f 100644

--- a/sandbox/win/src/broker_services.cc

+++ b/sandbox/win/src/broker_services.cc

@@ -446,10 +446,10 @@ ResultCode BrokerServicesBase::SpawnTarget(const wchar_t* exe_path,

if (stderr_handle != stdout_handle && stderr_handle != INVALID_HANDLE_VALUE)

inherited_handle_list.push_back(stderr_handle);

- HandleList policy_handle_list = policy_base->GetHandlesBeingShared();

+ const HandleList& policy_handle_list = policy_base->GetHandlesBeingShared();

for (auto handle : policy_handle_list)

- inherited_handle_list.push_back(handle);

+ inherited_handle_list.push_back(handle->Get());

if (inherited_handle_list.size())

++attribute_count;