Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229153003: [Telemetry] Copy typ library to telemetry/third_party. (Closed)

Created:
5 years, 5 months ago by nednguyen
Modified:
5 years, 5 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Copy typ library to telemetry/third_party. Update the references in telemetry/ to use telemetry/third_party instead of src/third_party/ BUG=472672 Committed: https://crrev.com/be672cde8b6172d8e9c73f6556218b23e79cf84a Cr-Commit-Position: refs/heads/master@{#338386}

Patch Set 1 #

Patch Set 2 : Remove typ from telemetry/bootstrap_deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-35 lines, --32 lines) Patch
M tools/telemetry/PRESUBMIT.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/bootstrap_deps View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/testing/run_tests.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/third_party/typ/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/README.rst View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/pylintrc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/run View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/setup.cfg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/setup.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/tools/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/tools/cov.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/__main__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/arg_parser.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/fakes/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/fakes/host_fake.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/fakes/test_result_server_fake.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/fakes/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/fakes/tests/host_fake_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/fakes/tests/test_result_server_fake_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/host.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/json_results.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/pool.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/printer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/runner.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/stats.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/test_case.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/arg_parser_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/host_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/json_results_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/main_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/pool_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/printer_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/runner_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/stats_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/tests/test_case_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/third_party/typ/typ/version.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
nednguyen
5 years, 5 months ago (2015-07-10 19:39:34 UTC) #2
sullivan
lgtm
5 years, 5 months ago (2015-07-10 19:45:09 UTC) #3
aiolos (Not reviewing)
lgtm
5 years, 5 months ago (2015-07-10 19:55:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229153003/1
5 years, 5 months ago (2015-07-10 19:57:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/79206) (exceeded global retry quota)
5 years, 5 months ago (2015-07-10 20:36:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229153003/1
5 years, 5 months ago (2015-07-10 20:38:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/79235) (exceeded global retry quota)
5 years, 5 months ago (2015-07-10 21:24:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229153003/20001
5 years, 5 months ago (2015-07-10 21:37:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 22:46:54 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 22:47:55 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/be672cde8b6172d8e9c73f6556218b23e79cf84a
Cr-Commit-Position: refs/heads/master@{#338386}

Powered by Google App Engine
This is Rietveld 408576698