Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1229133005: Fix for single-process WebUI transition CHECK failure.

Created:
5 years, 5 months ago by Krzysztof Olczyk
Modified:
5 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for single-process WebUI transition CHECK failure. Don't ensure, in single-process mode, that WebUI render views are the only ones in the process, as it makes no sense - we have single process only and no process-separation is expected. This allows testing navigation between WebUI and standard pages in single-process mode.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Krzysztof Olczyk
5 years, 5 months ago (2015-07-20 11:14:33 UTC) #2
Krzysztof Olczyk
Hi nasko, this is a reland of https://codereview.chromium.org/298133002/ as suggested by sergiyb in the comment ...
5 years, 5 months ago (2015-07-20 11:15:39 UTC) #3
nasko
On 2015/07/20 11:15:39, Krzysztof Olczyk wrote: > Hi nasko, > > this is a reland ...
5 years, 5 months ago (2015-07-20 11:43:25 UTC) #4
Krzysztof Olczyk
On 2015/07/20 at 11:43:25, nasko wrote: > On 2015/07/20 11:15:39, Krzysztof Olczyk wrote: > > ...
5 years, 5 months ago (2015-07-20 11:49:06 UTC) #5
nasko
LGTM
5 years, 5 months ago (2015-07-20 11:49:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229133005/1
5 years, 5 months ago (2015-07-20 11:51:24 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 12:06:18 UTC) #10
Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

Powered by Google App Engine
This is Rietveld 408576698