media/base/audio_splicer_unittest.cc - Issue 1229123002: Log audio splice sanitizer warnings and errors to media-internals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/audio_splicer_unittest.cc

Issue 1229123002: Log audio splice sanitizer warnings and errors to media-internals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address xhwang@'s comments and fix the unit test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/audio_splicer_unittest.cc

diff --git a/media/base/audio_splicer_unittest.cc b/media/base/audio_splicer_unittest.cc

index d64302c7627349cd7a641ca8597a0e40f56075e4..7b226bb07598a50d6ce2d28b32022bc3e43b118b 100644

--- a/media/base/audio_splicer_unittest.cc

+++ b/media/base/audio_splicer_unittest.cc

@@ -25,7 +25,7 @@ static const int kDefaultBufferSize = 100;

class AudioSplicerTest : public ::testing::Test {

public:

AudioSplicerTest()

- : splicer_(kDefaultSampleRate),

+ : splicer_(kDefaultSampleRate, new MediaLog()),

input_timestamp_helper_(kDefaultSampleRate) {

input_timestamp_helper_.SetBaseTimestamp(base::TimeDelta());

}

« no previous file with comments | « media/base/audio_splicer.cc ('k') | media/renderers/audio_renderer_impl.cc » ('j') | no next file with comments »