Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1229113002: Revert of WebWaitableEvent: implement new API with ResetPolicy and InitialState arguments (Closed)

Created:
5 years, 5 months ago by pdr.
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WebWaitableEvent: implement new API with ResetPolicy and InitialState arguments (patchset #4 id:60001 of https://codereview.chromium.org/1225243002/) Reason for revert: I think this patch is causing compile failures: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/107872/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > WebWaitableEvent: implement new API with ResetPolicy and InitialState arguments > > To support manual reset event in blink, implement new blink API > to create WebWaitableEvent with two new arguments. > > BUG=507224 > > Committed: https://crrev.com/bffe514b23e06dc98b3cba2601f69ade39bdb5fa > Cr-Commit-Position: refs/heads/master@{#338045} TBR=kinuko@chromium.org,tkent@chromium.org,toyoshim@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507224

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -20 lines) Patch
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/blink_platform_impl.cc View 2 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pdr.
Created Revert of WebWaitableEvent: implement new API with ResetPolicy and InitialState arguments
5 years, 5 months ago (2015-07-09 18:45:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229113002/1
5 years, 5 months ago (2015-07-09 18:46:05 UTC) #2
Takashi Toyoshima
Can I land this https://codereview.chromium.org/1228713005/ instread? Otherwise, this API update looks hard to handle.
5 years, 5 months ago (2015-07-09 18:48:54 UTC) #4
pdr.
5 years, 5 months ago (2015-07-09 19:05:39 UTC) #6
Message was sent while issue was closed.
On 2015/07/09 at 18:48:54, toyoshim wrote:
> Can I land this https://codereview.chromium.org/1228713005/ instread?
> Otherwise, this API update looks hard to handle.

I've closed this CL. Can you please roll out as you see fit?

Powered by Google App Engine
This is Rietveld 408576698