Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2780)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1229083005: clang/win: Add back /fallback for asan builds for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index f7b3a7594987043ebef1746eb7dbbb5d735f9116..ed29e60fe388a47dde5ed9aa941732bba3b1931c 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -127,6 +127,9 @@ config("compiler") {
} else {
cflags += [ "-m64" ]
}
+ if (is_asan) {
+ cflags += [ "/fallback" ]
+ }
if (exec_script("//build/win/use_ansi_codes.py", [], "trim string") ==
"True") {
cflags += [
@@ -699,7 +702,8 @@ config("runtime_library") {
default_warning_flags = []
default_warning_flags_cc = []
if (is_win) {
- if (!is_clang || current_cpu != "x86") {
+ # TODO(thakis): Make this unconditional once llvm.org/PR24167 is fixed.
+ if (!is_clang || !is_asan) {
default_warning_flags += [ "/WX" ] # Treat warnings as errors.
}
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698