Issue 1229083005: clang/win: Add back /fallback for asan builds for now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1229083005: clang/win: Add back /fallback for asan builds for now. (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
Reid Kleckner

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

clang/win: Add back /fallback for asan builds for now. In asan builds, a few translation units still fall back to CL, see http://llvm.org/PR24167 Also update the gn files to pass /WX (warnings-as-errors) in 32-bit non-asan clang builds. BUG=82385 TBR=rnk Committed: https://chromium.googlesource.com/chromium/src/+/28d32d89e5081223fab2982dc97252fd5150e721

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	build/config/compiler/BUILD.gn	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Nico

Committed patchset #1 (id:1) manually as 28d32d89e5081223fab2982dc97252fd5150e721 (presubmit successful).

5 years, 5 months ago (2015-07-17 20:05:25 UTC) #4

Message was sent while issue was closed.

lgtm