Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1229083002: Clean up some detach logic in RenderFrameImpl. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some detach logic in RenderFrameImpl. There's no reason to gate RenderWidget frame unregistration on the kSitePerProcess flag; it should be gated using the same policy as the creation of the RenderWidget. Moving the RenderWidget cleanup out of the is_subframe block also paves the way for when the main frame also has a RenderWidget. BUG=419087 R=creis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/3403bc5413575b3b05842d79b8547d58308d0b7d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Less braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcheng
5 years, 5 months ago (2015-07-09 20:40:58 UTC) #2
Charlie Reis
LGTM with nit. https://codereview.chromium.org/1229083002/diff/1/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/1229083002/diff/1/content/renderer/render_frame_impl.cc#newcode2170 content/renderer/render_frame_impl.cc:2170: if (render_widget_) { nit: No braces. ...
5 years, 5 months ago (2015-07-09 21:06:19 UTC) #3
dcheng
5 years, 5 months ago (2015-07-09 21:13:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3403bc5413575b3b05842d79b8547d58308d0b7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698