Add BookmarkUndoServiceTest.UndoRemoveFolderWithSubfolders

Add BookmarkUndoServiceTest.UndoRemoveFolderWithSubfolders

Add a test to make sure we do not crash and bookmarks are
restored to the proper subfolder when undoing the removal of a
folder with multiple subfolders.

BUG=474123
Committed: https://crrev.com/8aa4487a40c3f9bd7a36100cab0e330b9fa9b2cb
Cr-Commit-Position: refs/heads/master@{#339670}

[Theresa, 2015-07-20 16:39:52]

twellington@chromium.org changed reviewers:
+ sky@chromium.org

[Theresa, 2015-07-20 16:39:53]

ptal

[sky, 2015-07-20 20:01:35]

LGTM

https://codereview.chromium.org/1229063002/diff/1/components/undo/bookmark_un...
File components/undo/bookmark_undo_service_test.cc (right):

https://codereview.chromium.org/1229063002/diff/1/components/undo/bookmark_un...
components/undo/bookmark_undo_service_test.cc:416: model->AddURL(sub_folder2, 0,
ASCIIToUTF16("bar"), GURL("http://www.bar.com"));
nit: > 80.

https://codereview.chromium.org/1229063002/diff/1/components/undo/bookmark_un...
components/undo/bookmark_undo_service_test.cc:424: new_folder =
model->other_node()->GetChild(0);
I think this code would be clearer if you didn't reuse the existing variables.
For example, use restored_new_folder instead of new_folder.

[Theresa, 2015-07-21 00:42:54]

https://codereview.chromium.org/1229063002/diff/1/components/undo/bookmark_un...
File components/undo/bookmark_undo_service_test.cc (right):

https://codereview.chromium.org/1229063002/diff/1/components/undo/bookmark_un...
components/undo/bookmark_undo_service_test.cc:416: model->AddURL(sub_folder2, 0,
ASCIIToUTF16("bar"), GURL("http://www.bar.com"));
On 2015/07/20 20:01:35, sky wrote:
> nit: > 80.

Done.

https://codereview.chromium.org/1229063002/diff/1/components/undo/bookmark_un...
components/undo/bookmark_undo_service_test.cc:424: new_folder =
model->other_node()->GetChild(0);
On 2015/07/20 20:01:35, sky wrote:
> I think this code would be clearer if you didn't reuse the existing variables.
> For example, use restored_new_folder instead of new_folder.

Done.

[Theresa, 2015-07-21 16:51:06]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2015-07-21 16:51:07]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1229063002/#ps40001
(title: "Don't set sub_folder1* (now unused)")

[commit-bot: I haz the power, 2015-07-21 16:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1229063002/40001

[commit-bot: I haz the power, 2015-07-21 17:13:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-21 17:14:54]

Patchset 3 (id:??) landed as
https://crrev.com/8aa4487a40c3f9bd7a36100cab0e330b9fa9b2cb
Cr-Commit-Position: refs/heads/master@{#339670}